Skip to content

Commit

Permalink
JENKINS-55605 - Remove restriction that prevented clicking/url updati…
Browse files Browse the repository at this point in the history
…ng on unfinished nodes, or parallel nodes (#2018)

Removed the restriction on clicking on various nodes.
The system seems to redirect to a random node if the node id is invalid (so kinda the same behaviour as now)
This way whatever the state is, we try to show the logs for it.

Was not able to find any existing reason why this restriction is in place
  • Loading branch information
halkeye authored Aug 27, 2019
1 parent 07bbd50 commit db8d55d
Showing 1 changed file with 3 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -270,15 +270,11 @@ export default class Pipeline extends Component {
pathArray.shift();
nextPath = `/${pathArray.join('/')}`;
}
// check whether we have a parallel node or seq parallel nodes
const isParallel = nextNode.isParallel || (nextNode.firstParent && nextNode.parent != nextNode.firstParent);

// see whether we need to update the state
if (nextNode.state === 'FINISHED' || isParallel) {
nextPath = `${nextPath}/${id}`; // only allow node param in finished nodes
}
nextPath = `${nextPath}/${id}`;

// see whether we need to update the karaoke mode
if ((nextNode.state === 'FINISHED' || isParallel) && this.karaoke) {
if (nextNode.state === 'FINISHED' && this.karaoke) {
logger.debug('turning off karaoke since we do not need it anymore because focus is on a finished node.');
this.stopKaraoke();
}
Expand Down

0 comments on commit db8d55d

Please sign in to comment.