Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for AWS Credentials #303

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chris-h-phillips
Copy link

As suggested here: #237

Adds AwsAccessKeysCredentials which will allow other plugins that need to interact with AmazonWebServicesCredentials instances from the aws-credentials plugin e.g. the amazon-ecr plugin.

Testing done

Added AWSAccessKeysCredentialsIT which follows the testing patterns of the other credential types.

Submitter checklist

@asaf-the-ancient
Copy link

Guys, any update on this?

@pavriet-boxtal
Copy link

Would be nice to have that

@chriskilding
Copy link
Contributor

chriskilding commented Mar 28, 2024

Hi @chris-h-phillips, sorry for not getting round to this sooner.

I have (slowly) been trying to solve the problem of how to support vendor-proprietary credential types in the plugin, but without bringing them into the plugin core (where, effectively, they would have to be kept around forever - even if a vendor were to go out of business, or deprecate their proprietary credential type in favour of another - since there is no way to remove things without breaking changes).

To that end I have created #298, which allows the factory for each credential type to be queried and loaded dynamically with the Java ServiceLoader.

If you (or someone else interested in this PR) would be able to rework this PR using #298 as a base, that would be great!

@chriskilding
Copy link
Contributor

(And once that's done, the next step would be to merge #298, and then create separate add-on plugins for each vendor-proprietary credential type - starting with this one.)

With this architecture people can add the respective vendor-proprietary add-on plugins that they need to their installations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants