Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AWS credentials #237

Open
andyshinn opened this issue Oct 10, 2022 · 2 comments
Open

Support AWS credentials #237

andyshinn opened this issue Oct 10, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@andyshinn
Copy link

What feature do you want to see added?

Support the AWS credential type from https://github.com/jenkinsci/aws-credentials-plugin so we can specify a role, MFA, etc.. Maybe these can be additional tags such as jenkins:credentials:assume_role, jenkins:credentials:mfa_arn, etc.

Upstream changes

No response

@andyshinn andyshinn added the enhancement New feature or request label Oct 10, 2022
@chriskilding
Copy link
Contributor

This is tangentially related to #236

In that PR I'm adding support to let the plugin authenticate with AWS using a static key pair, supplied inline in Jenkins config. (This is to help users who want to use the plugin, but who only have administrative control of Jenkins - and not the box it's running on.) There were 2 options for supplying the key pair:

  1. Have the plugin consume an AWSCredentials object from the Credentials API
  2. Supply the access key and secret key values directly (with encryption / protection on the secret key field)

Given the presence of this request I think approach (1) is now definitely out of the question; if the plugin supplied AWSCredentials as well as consuming it, then it would run into a chicken-and-egg initialisation error. (I.e. potentially asking the uninitialised version of itself for a credential which it needs to initialise itself.) This vindicates approach (2) which I have used.

chris-h-phillips added a commit to chris-h-phillips/aws-secrets-manager-credentials-provider-plugin that referenced this issue Oct 13, 2023
chris-h-phillips added a commit to chris-h-phillips/aws-secrets-manager-credentials-provider-plugin that referenced this issue Oct 13, 2023
@ychaharau
Copy link

Hi Team! Thank you for raising the issue! Is there a timeframe or deadline to add this enhancement? I'm looking forward to this so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants