[fix] Update credential icons (#216)

Co-authored-by: Chris Kilding <[email protected]>

Jenkinsfile

@@ -1,4 +1,4 @@
-def recentLTS = "2.289.3"
+def recentLTS = "2.346.3"
 def configurations = [
     [ platform: "linux", jdk: "8", jenkins: null ],
     [ platform: "linux", jdk: "8", jenkins: recentLTS, javaLevel: "8" ],

pom.xml

@@ -44,15 +44,15 @@
         <revision>1</revision>
         <changelist>999999-SNAPSHOT</changelist>
         <java.level>8</java.level>
-        <jenkins.version>2.289.3</jenkins.version>
+        <jenkins.version>2.346.3</jenkins.version>
     </properties>
 
     <dependencyManagement>
         <dependencies>
             <dependency>
                 <groupId>io.jenkins.tools.bom</groupId>
-                <artifactId>bom-2.289.x</artifactId>
-                <version>1500.ve4d05cd32975</version>
+                <artifactId>bom-2.346.x</artifactId>
+                <version>1654.vcb_69d035fa_20</version>
                 <scope>import</scope>
                 <type>pom</type>
             </dependency>

src/main/java/io/jenkins/plugins/credentials/secretsmanager/factory/certificate/AwsCertificateCredentials.java

@@ -68,7 +68,7 @@ public String getDisplayName() {
 
         @Override
         public String getIconClassName() {
-            return "icon-credentials-certificate";
+            return "icon-application-certificate";
         }
 
         @Override

src/main/java/io/jenkins/plugins/credentials/secretsmanager/factory/ssh_user_private_key/AwsSshUserPrivateKey.java

@@ -61,7 +61,7 @@ public String getDisplayName() {
 
         @Override
         public String getIconClassName() {
-            return "icon-ssh-credentials-ssh-key";
+            return "symbol-fingerprint";
         }
 
         @Override

src/main/java/io/jenkins/plugins/credentials/secretsmanager/factory/username_password/AwsUsernamePasswordCredentials.java

@@ -46,7 +46,7 @@ public String getDisplayName() {
 
         @Override
         public String getIconClassName() {
-            return "icon-credentials-userpass";
+            return "symbol-id-card";
         }
 
         @Override

src/test/java/io/jenkins/plugins/credentials/secretsmanager/util/PluginConfigurationForm.java

@@ -25,11 +25,11 @@ public HtmlSelect getDropdownList(String settingName) {
 
     private static class XPaths {
         private static String dropdownList(String settingName) {
-            return String.format("//div[contains(@class, 'setting-name') and normalize-space(text()) = '%s']/following-sibling::div[contains(@class, 'setting-main')]/select[contains(@class, 'dropdownList')]", settingName);
+            return String.format("//div[contains(@class, 'jenkins-form-label') and normalize-space(text()) = '%s']/following-sibling::div[contains(@class, 'jenkins-select')]/select", settingName);
         }
 
         private static String repeatableAddButtons(String settingName) {
-            return String.format("//div[contains(@class, 'setting-name') and text()='%s']/following-sibling::div[@class='setting-main']//span[contains(string(@class),'repeatable-add')]//button[contains(text(), 'Add')]", settingName);
+            return String.format("//div[contains(@class, 'jenkins-form-label') and text()='%s']/following-sibling::div[@class='setting-main']//span[contains(string(@class),'repeatable-add')]//button[contains(text(), 'Add')]", settingName);
         }
     }
 }