Skip to content
This repository has been archived by the owner on Nov 11, 2020. It is now read-only.

build: simplified and hadolintd Dockerfile #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

build: simplified and hadolintd Dockerfile #5

wants to merge 1 commit into from

Conversation

masseybradley
Copy link

@masseybradley masseybradley commented Mar 7, 2020

Refactors the Dockerfile build: removes mkdir commands (directories are created with WORKDIR instructions), pipes curl packages to tar, makes variables easier to override in builds using docker ARG's to set the ENV (note: might break the jx step create pr), fixes the helm3 download using the ENV variable, aliases the docker stages, consolidates and sorts and splits yum package installation on multiple lines following best practices. Dockerfile can be linted using hadolint: docker run --rm -i hadolint/hadolint < Dockerfile - directories created by make are ignored inline.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant