Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused upload permissions from kohsuke #3109

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

daniel-beck
Copy link
Contributor

This PR removes unused upload permissions from @kohsuke.

The only things released by KK in the last five years were Jenkins releases (ended when automation took over in mid 2021) and https://github.com/kohsuke/localizer:

curl --silent --header 'Content-Type: text/plain' --user you:yourpass --data-binary 'items.find({"$and":[{"repo":"releases"},{"created_by":"kohsuke"},{"created":{"$gt":"2018-02-01T00:00:00.00+00:00"}}]}).include("path","name","created")' https://repo.jenkins-ci.org/api/search/aql | jq --raw-output '.results[] | "\( .created ): \( .path )/\( .name ))"'

This PR adds new permissions files for localizer itself and localizer-maven-plugin in anticipation of the removal of KK's unrestricted upload permissions in Artifactory (CC @Wadeck @dduportal).

Removal of component/plugin upload permissions was previously discussed with @kohsuke in March 2021 but I never got around to submitting this PR (and then I simply forgot).

Copy link
Collaborator

@Wadeck Wadeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine at this point it does not worth adjusting the permissions per repo as KK is still an org owner? :)

Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking care of this Daniel!

@NotMyFault
Copy link
Member

@daniel-beck (How) Do we want to proceed with this PR? It's dormenting as draft for a few months now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants