-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add updating Jenkins section in User's Handbook #5888
Add updating Jenkins section in User's Handbook #5888
Conversation
Hi @Vandit1604 Try adding a file with your GitHub username as the file name in here for the authors: https://github.com/jenkins-infra/jenkins.io/tree/master/content/_data/authors |
@krisstern Hi I created this PR #5890 doing what you instructed |
Maybe it would be better originally to have the changes you made in PR #5890 to this PR instead. Now you will have to wait until that PR is merged and pull the latest changes to this PR later before every check is passed. |
I can close that PR #5890 and commit the changes to this PR so this can be merged/reviewed much faster |
Sure |
@Vandit1604 It appears there are some bugs to be patched before the checks are passed: [2023-01-07T14:30:23.323Z] Failing build due to warnings in log output:
[2023-01-07T14:30:23.323Z] asciidoctor: WARNING: doc/book/updating/_update-wizard.adoc: line 16: section title out of sequence: expected level 2, got level 4
[2023-01-07T14:30:23.323Z] /home/jenkins/workspace/Websites_jenkins.io_PR-5888/content/download/index.html.haml:156: warning: calling URI.open via Kernel#open is deprecated, call URI.open directly or use URI#open
[2023-01-07T14:30:23.323Z] /home/jenkins/workspace/Websites_jenkins.io_PR-5888/content/download/index.html.haml:97: warning: calling URI.open via Kernel#open is deprecated, call URI.open directly or use URI#open
[2023-01-07T14:30:23.323Z] /home/jenkins/workspace/Websites_jenkins.io_PR-5888/content/_layouts/corebaseline.html.haml:9: warning: calling URI.open via Kernel#open is deprecated, call URI.open directly or use URI#open
[2023-01-07T14:30:23.323Z] /home/jenkins/workspace/Websites_jenkins.io_PR-5888/content/_partials/changelog-changes.xml.haml:11: warning: Using the last argument as keyword parameters is deprecated
[2023-01-07T14:30:23.323Z] /home/jenkins/workspace/Websites_jenkins.io_PR-5888/content/_partials/changelog-changes.xml.haml:13: warning: Using the last argument as keyword parameters is deprecated
[2023-01-07T14:30:23.323Z] /home/jenkins/workspace/Websites_jenkins.io_PR-5888/content/_partials/changelog-changes.xml.haml:15: warning: Using the last argument as keyword parameters is deprecated
[2023-01-07T14:30:23.323Z] /home/jenkins/workspace/Websites_jenkins.io_PR-5888/content/_partials/changelog-changes.xml.haml:16: warning: Using the last argument as keyword parameters is deprecated
[2023-01-07T14:30:23.323Z] /home/jenkins/workspace/Websites_jenkins.io_PR-5888/content/_partials/changelog-changes.xml.haml:17: warning: Using the last argument as keyword parameters is deprecated
[2023-01-07T14:30:23.324Z] /home/jenkins/workspace/Websites_jenkins.io_PR-5888/content/_partials/changelog-changes.xml.haml:20: warning: Using the last argument as keyword parameters is deprecated
[2023-01-07T14:30:23.324Z] /home/jenkins/workspace/Websites_jenkins.io_PR-5888/content/_partials/changelog-changes.xml.haml:22: warning: Using the last argument as keyword parameters is deprecated
[2023-01-07T14:30:23.324Z] /home/jenkins/workspace/Websites_jenkins.io_PR-5888/content/_partials/changelog-changes.xml.haml:24: warning: Using the last argument as keyword parameters is deprecated
[2023-01-07T14:30:23.324Z] /home/jenkins/workspace/Websites_jenkins.io_PR-5888/content/_partials/changelog-changes.xml.haml:26: warning: Using the last argument as keyword parameters is deprecated
[2023-01-07T14:30:23.324Z] /home/jenkins/workspace/Websites_jenkins.io_PR-5888/content/_partials/changelog-changes.xml.haml:27: warning: Using the last argument as keyword parameters is deprecated
[2023-01-07T14:30:23.324Z] /home/jenkins/workspace/Websites_jenkins.io_PR-5888/content/_partials/changelog-changes.xml.haml:28: warning: Using the last argument as keyword parameters is deprecated
[2023-01-07T14:30:23.324Z] /home/jenkins/workspace/Websites_jenkins.io_PR-5888/content/_partials/changelog-changes.xml.haml:9: warning: Using the last argument as keyword parameters is deprecated
[2023-01-07T14:30:23.324Z] /home/jenkins/workspace/Websites_jenkins.io_PR-5888/content/security/advisories/rss.xml.haml:40: warning: Using the last argument as keyword parameters is deprecated
[2023-01-07T14:30:23.324Z] /home/jenkins/workspace/Websites_jenkins.io_PR-5888/content/security/advisories/rss.xml.haml:42: warning: Using the last argument as keyword parameters is deprecated
[2023-01-07T14:30:23.324Z] /home/jenkins/workspace/Websites_jenkins.io_PR-5888/content/security/advisories/rss.xml.haml:46: warning: Using the last argument as keyword parameters is deprecated
[2023-01-07T14:30:23.324Z] /home/jenkins/workspace/Websites_jenkins.io_PR-5888/content/security/advisories/rss.xml.haml:48: warning: Using the last argument as keyword parameters is deprecated
[2023-01-07T14:30:23.324Z] /home/jenkins/workspace/Websites_jenkins.io_PR-5888/content/security/advisories/rss.xml.haml:52: warning: Using the last argument as keyword parameters is deprecated |
Currently the images are not showing yet in the preview version at https://deploy-preview-5888--jenkins-io-site-pr.netlify.app/doc/book/updating and some pages like the one on Windows appear to need some polish up (like with additional description/explanation for each step added). I will let the @jenkins-infra/copy-editors team to review the PR in more depth. |
I'll also correct the heading size as right now the page looks like a mess |
For an example of a working link to images:
This is taken from https://raw.githubusercontent.com/jenkins-infra/jenkins.io/master/content/doc/book/installing/windows.adoc |
Sure, sounds like a good idea |
I have added the images just like that after seeing how images were added in other pages |
Sorry for the commits |
You have for the image link now for example: I think it should really be like the following with boxshadow to keep the styling consistent: [.boxshadow]
image:updating/check-jenkins-version.png[alt="Unlock Jenkins page",width=80%] |
And @Vandit1604 You may want to put your image in here instead: https://github.com/jenkins-infra/jenkins.io/tree/master/content/doc/book/resources |
this was how it was before i checked in asciidoctor docs there it is mentioned you can use either (:) or (::) colon but i'll change it to one colon (:) |
Look I gave you the exact path you are supposed to use, in a folder called |
@Vandit1604 The paths you are using are currently all broken paths. |
Sorry |
Given the current level of traction on this PR, I believe it may be best to close it for now. I am happy to revisit and continue working on it in the future should the need arise. |
Windows and Linux sections are based on my knowledge and @krisstern helped in macOS section for upgrading jenkins other than that every thing is compiled by me after reading blogs and questions answered on community forum of jenkins
feel free to add upgrading instructions for other sections
this closes #5059