-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update single sign on keycloak section with new images #299
Conversation
Task linked: CU-86bzwgc5f Update Single Sign-on section |
WalkthroughThe documentation for setting up local development environments for the JeMPI project has been streamlined. Previously detailed steps for running Keycloak, JeMPI Backend, and UI separately have been consolidated into a single section. This new approach emphasizes cloning the JeMPI repository, updating configurations, and executing a local deployment script, enhancing clarity and efficiency for developers. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
documentation/sso.md (1)
48-48
: Format URLs as hyperlinks.Consider using Markdown syntax to format the URL as a hyperlink for better readability.
- Access : http://localhost:3000/login + Access: [http://localhost:3000/login](http://localhost:3000/login)Tools
Markdownlint
48-48: null
Bare URL used(MD034, no-bare-urls)
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- documentation/sso.md (1 hunks)
Additional context used
Markdownlint
documentation/sso.md
48-48: null
Bare URL used(MD034, no-bare-urls)
Additional comments not posted (4)
documentation/sso.md (4)
26-31
: LGTM!The instructions for cloning the JeMPI repository and navigating into it are clear and efficient.
33-37
: LGTM! Verify environment variable application.The environment variable settings are clear. Ensure users set these variables in the correct environment (e.g., terminal session, configuration file).
39-43
: LGTM! Verify script execution permissions.The instructions for executing the local deployment script are clear. Ensure users have the necessary permissions to execute the script.
45-54
: LGTM! Verify image accessibility.The visual references and instructions enhance clarity. Ensure that all images are correctly linked and accessible.
Tools
Markdownlint
48-48: null
Bare URL used(MD034, no-bare-urls)
Summary by CodeRabbit