Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Linking new golden record fixed #190

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

harmochiky
Copy link
Collaborator

@harmochiky harmochiky commented Feb 29, 2024

Ticket: N/A
Other Related Tickets: N/A

Describe of changes


This PR Includes the bug fix for creating a new golden record and linking a new golden record for a notification. This change includes usage of the currentGoldenId request than the newGoldenId which didnt exist in the patchIidNewGidLink function in the JeMPI_LibAPI

Change from

 ...
 
            replyTo -> new BackEnd.PatchIidNewGidLinkRequest(
                                                                                             replyTo,
                                                                                             newGoldenId,
                                                                                             patientId,
                                                                                             2.0F),
   ...

Change to

 ...
 
            replyTo -> new BackEnd.PatchIidNewGidLinkRequest(
                                                                                             replyTo,
                                                                                             currentGoldenId,
                                                                                             patientId,
                                                                                             2.0F),
   ...

How to test / configure


You may press the "Create new golden record" button on an open notification or the "Link" button on a blocked record in which either a successful message should popup and a redirect to the audit log should happen without an error

@walisc
Copy link
Collaborator

walisc commented Mar 1, 2024

Hi @harmochiky. Could you please format the description for easier readability. Also in your description could you explain what the problem was and how your change fixes it. As an example see #168

Lastly I think you need to pull dev into your branch, and push again. You PR needs to go through some checks, which it hasn't yet.

Copy link
Collaborator

@walisc walisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@walisc walisc merged commit afd9e6c into jembi:dev Mar 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants