Add setting for delay of start of video #4025
Open
+37
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsvanvelzen
requested changes
Sep 28, 2024
app/src/main/java/org/jellyfin/androidtv/preference/UserPreferences.kt
Outdated
Show resolved
Hide resolved
| @@ -646,7 +646,7 @@ public void run() { | |||
| if (mVideoManager != null) | |||
| mVideoManager.start(); | |||
| } | |||
| }, 750); | |||
| }, userPreferences.getValue().get(UserPreferences.Companion.getVideoStartDelay())); | |||
There was a problem hiding this comment.
The comment above (about why this is delayed) is inaccurate and could be removed. Additionally a fast-path when there is no delay would be nice to have.
There was a problem hiding this comment.
By fast-path I assumed you meant to add a condition to skip the mHandler.postDelayed logic if the delay is set to 0. I have added a check for this.
Update default for video start delay. Update video start delay string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This updates the delay when starting the video player to be user configurable. Having this as configurable will help people who have displays that are slow to change resolution or refresh rate. I have two displays and a soundbar that take longer than the 0.75 seconds default to change format or mode. With this setting the first few seconds of the video and audio are not missed.
Issues
None I can find.