Display length of show/movie in hour minute format (like web client) #3878
+14
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahvogt
force-pushed
the
fixes_issue_2806
branch
from
32c36d3
to
768cd0e
Compare
nielsvanvelzen
requested changes
Aug 18, 2024
app/src/main/java/org/jellyfin/androidtv/ui/itemdetail/FullDetailsFragment.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/androidtv/ui/itemdetail/FullDetailsFragment.java
Outdated
Show resolved
Hide resolved
|
As requested, in 88ad0e0 I reverted the translation files, so this PR won't change them directly. |
nielsvanvelzen
requested changes
Aug 27, 2024
Co-authored-by: Niels van Velzen <[email protected]>
|
Hey @noahvogt, are you still interested in finishing this pull request? it's currently waiting for you to address my comment above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display length of show/movie in hour minute format
Changes
Currently the length of shows/movies shown in FullDetailsFragment.java is in minutes only, or to say as a regex
[0-9]+ min. With my changes, it now shows in the format[0-9]+h [0-9][0-9]?m. Note that the minutes are not zeropadded (displaying eg2h 02minstead of2h 2m) as this is the way the web client does it as well.For more consistency with the main web client, I decided to just change it instead of adding an option so that the user can switch between both display methods. But if that's prefered, I can change it before resubmitting.
Issues
Fixes #2806