Add shuffle button for music video collection #3861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -212,6 +212,18 @@ class SdkPlaybackHelper( | |||
| } | |||
| } | |||
|
|
|||
| BaseItemKind.COLLECTION_FOLDER -> { | |||
There was a problem hiding this comment.
I think adding COLLECTION_FOLDER to the BaseItemKind.SERIES, BaseItemKind.SEASON, BaseItemKind.BOX_SET, BaseItemKind.FOLDER line makes more sense. That results in (mostly) the same request.
| @@ -719,6 +722,23 @@ private void addTools() { | |||
| //Add tools | |||
| int size = Utils.convertDpToPixel(requireContext(), 26); | |||
|
|
|||
| if (mFolder.getCollectionType() == CollectionType.MUSICVIDEOS) | |||
There was a problem hiding this comment.
What about other collection types like music (when browsing albums/artists etc.)?
|
Hey @dmdymov, are you still interested in finishing this pull request? it's currently waiting for you to address my 2 comments above. |
|
@nielsvanvelzen yes, I am. Busy month. I'll try to finish this pull request next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added "Shuffle all" button to the music video collection toolbar. Once clicked, it creates a random video queue with the collection folder as a source and plays it with
PlaybackHelper. For the collection folder source to work I added a new type option toSdkPlaybackHelper. Tested it on my NVIDIA Shield, works fine.Issues
None, as far as I know.