Issue 1431: fix copy multiple locators + small refactoring #1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariiaNebesnova
changed the title
Iogsotot
reviewed
Aug 2, 2023
Comment on lines
+5
to
+14
| switch (match) { | ||
| case "\\": | ||
| return "\\\\\\\\"; | ||
| case "'": | ||
| return "\\'"; | ||
| case "\n": | ||
| return "\\n"; | ||
| default: | ||
| return match; | ||
| } |
There was a problem hiding this comment.
It looks like magic strings to me now.
Is it possible for you to add an explanation or constants with meaningful names to the code explaining them?
There was a problem hiding this comment.
sorry, not my code. but it's covered with tests, hope they could help you to understand what's going on
There was a problem hiding this comment.
I just refactored location of this function
There was a problem hiding this comment.
what tests cover this code?
There was a problem hiding this comment.
"escape symbols in locator" from https://github.com/jdi-testing/jdn-ai/pull/1439/files#diff-c3f66e9470dbf46aa684c5ffec7394f39ed3ff49ba5e11d6aa1427f317a57938
kostrubin
approved these changes
Aug 2, 2023
Iogsotot
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.