Skip to content

Commit

Permalink
Merge pull request #1456 from jdi-testing/issue_1398
Browse files Browse the repository at this point in the history
 issue_1398: add initial state STARTED in jdn-status attr for all locators
  • Loading branch information
Iogsotot authored Aug 9, 2023
2 parents 7712027 + 38fae03 commit 5c13bdc
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"name": "JDN",
"description": "JDN – helps Test Automation Engineer to create Page Objects in the test automation framework and speed up test development",
"devtools_page": "index.html",
"version": "3.13.555",
"version": "3.13.556",
"icons": {
"128": "icon128.png"
},
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "jdn-ai-chrome-extension",
"version": "3.13.555",
"version": "3.13.556",
"description": "jdn-ai chrome extension",
"scripts": {
"start": "webpack --watch --env devenv",
Expand Down
1 change: 1 addition & 0 deletions src/features/locators/reducers/identifyElements.thunk.ts
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ export const onLocatorsCreated: Middleware = (store) => (next) => (action) => {
const locators = action.payload;
const { generateXpath } = selectAutoGeneratingLocatorTypes(state as RootState, locators);
// generateCssSelector: false because it's run with attributes generation for performance reasons
// TODO: take generateCssSelector from selectAutoGeneratingLocatorTypes, when backend will be ready
// @ts-ignore
store.dispatch(runLocatorsGeneration({ locators, generateXpath, generateCssSelector: false }));
}
Expand Down
2 changes: 1 addition & 1 deletion src/pageServices/contentScripts/highlight.js
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ export const highlightOnPage = () => {
div.id = jdnHash;
div.className = getClassName(predictedElement);
div.setAttribute("jdn-highlight", true);
div.setAttribute("jdn-status", predictedElement.locator.taskStatus);
div.setAttribute("jdn-status", predictedElement.locator.taskStatus || LocatorTaskStatus.STARTED);
div.addEventListener("mouseover", () => {
tooltipTimer = setTimeout(() => {
showTooltip(coordinates);
Expand Down

0 comments on commit 5c13bdc

Please sign in to comment.