fixed escaping for copy option

jdi-testing · Jul 18, 2023 · 116e6cf · 116e6cf
1 parent 4413481
commit 116e6cf
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/src/common/utils/helpers.ts b/src/common/utils/helpers.ts
@@ -10,12 +10,11 @@ export const floatToPercent = (value: number) => {
 export const copyToClipboard = (text: string) => {
   // "\\\\3" - needed to get "\3" in 'eval()'
   const transformedText = text
-    .replace(/'/g, "\\'")
+    .replace(/\'/g, "\\\\'")
     .replace(/\n/g, "\\n")
     .replace(/#\\3/g, "#\\\\3")
     .replace(/=\\'\\3/g, "=\\'\\\\3") // two different cases for \\3 to avoid affecting something else...
-    .replace(/\\/g, "\\\\")
-    .replace(/"/g, '\\"');
+    .replace(/\"/g, '\\\\"');
   chrome.devtools.inspectedWindow.eval(`copy('${transformedText}')`);
 };
 

diff --git a/src/pageServices/contentScripts/generationData.js b/src/pageServices/contentScripts/generationData.js
@@ -107,15 +107,14 @@ export const getGenerationAttributes = () => {
 
     const isSelectorByGeneratorString = typeof selectorByGenerator === "string";
     const isSelectorByFinderString = typeof selectorByFinder === "string";
-    const transformSelector = (selector) => selector.replace(/"/g, "'");
 
     if (isSelectorByGeneratorString && isSelectorByFinderString) {
       const selector = selectorByGenerator.length < selectorByFinder.length ? selectorByGenerator : selectorByFinder;
-      return transformSelector(selector);
+      return selector;
     } else if (!isSelectorByFinderString && isSelectorByGeneratorString) {
-      return transformSelector(selectorByGenerator);
+      return selectorByGenerator;
     } else if (!isSelectorByGeneratorString && isSelectorByFinderString) {
-      return transformSelector(selectorByFinder);
+      return selectorByFinder;
     } else {
       return "CSS selector generation was failed";
     }