Upgrade #65
Open
Upgrade #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor changes to UI. Added API key to manifest. Updated prediction text to show both lines, makes it more clear.
Added toolbar.
|
Thanks. Could you check to see what's actualy casuing the build to fail. |
jackgris
reviewed
Oct 13, 2016
| <meta-data | ||
| android:name="com.google.android.geo.API_KEY" | ||
| android:value="API_KEY_HERE"/> | ||
| android:value="AIzaSyDv8K5B4U6M78r8JFufD0fTFpyycW7cmMk"/> |
There was a problem hiding this comment.
This is correct? It should not be like before?
|
No, everyone puts their own API key there. Yours is private so it shouldn't be shared. |
|
TY |
|
The build failed. check to see why it failed here and how it can be resolved https://travis-ci.org/jd-alexander/Google-Directions-Android/builds/167146779 |
…s only the initial segment. waypoints were not supported. I'll have to see if this affects me for transit. seems not so far.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Alexander,
I took the liberty of upgrading the library sample to the latest version of Google tools (gradle, SDKs and libraries, and so on).
Everything seems to still work.
Could you have a look and merge if everything is ok? I want to use your library in the future.
Regards,
Radu