Cleanup Rubocop config, fix offenses

jbox-web · Aug 28, 2024 · 89e152a · 89e152a
1 parent 4864774
commit 89e152a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 30 deletions.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -11,7 +11,7 @@ AllCops:
     - bin/*
     - spec/**/*
 
-Gemspec/AddRuntimeDependency:
+Gemspec/RequireMFA:
   Enabled: false
 
 Style/Documentation:
@@ -32,33 +32,6 @@ Layout/EmptyLinesAroundBlockBody:
 Layout/EmptyLinesAroundModuleBody:
   Enabled: false
 
-Layout/LineLength:
-  Enabled: false
-
-Metrics/MethodLength:
-  Max: 12
-
 Layout/HashAlignment:
   EnforcedColonStyle: table
   EnforcedHashRocketStyle: table
-
-Lint/RaiseException:
-  Enabled: true
-
-Lint/StructNewOverride:
-  Enabled: true
-
-Style/HashEachMethods:
-  Enabled: true
-
-Style/HashTransformKeys:
-  Enabled: true
-
-Style/HashTransformValues:
-  Enabled: true
-
-Gemspec/DevelopmentDependencies:
-  Enabled: false
-
-Gemspec/RequireMFA:
-  Enabled: false
diff --git a/lib/active_settings.rb b/lib/active_settings.rb
@@ -145,7 +145,6 @@ def traverse_config(hash)
       end
       result
     end
-    # rubocop:enable Metrics/MethodLength
 
     def traverse_array(array)
       array.map do |value|
@@ -160,6 +159,7 @@ def traverse_array(array)
         end
       end
     end
+    # rubocop:enable Metrics/MethodLength
 
     def freeze_config(hash)
       hash.each_value do |v|

diff --git a/lib/active_settings/validation/validate.rb b/lib/active_settings/validation/validate.rb
@@ -11,7 +11,8 @@ def validate!
 
         return if v_res.success?
 
-        raise ActiveSettings::Validation::Error, "ActiveSettings validation failed:\n\n#{ActiveSettings::Validation::Error.format(v_res, ActiveSettings.env_prefix)}"
+        message = ActiveSettings::Validation::Error.format(v_res, ActiveSettings.env_prefix)
+        raise ActiveSettings::Validation::Error, "ActiveSettings validation failed:\n\n#{message}"
       end
 
     end