Improve performance of execute under contention by using flat combiners #91
Conversation
|
I'm having a busy week, but I'm planning to read through this when I have time! |
| idleCount++; | ||
| } | ||
| return idleCount; | ||
| }); |
There was a problem hiding this comment.
I think we can extract this IdleStrategy to a singleton and avoid allocation cost.
| static IdleStrategy yield(int maxSpins) { | ||
| return idleCount -> { | ||
| if (idleCount < maxSpins) { | ||
| idleCount++; |
There was a problem hiding this comment.
Should these use onSpinWait? I think they'd need to move into the org.jboss.threads package for access.
There was a problem hiding this comment.
I don't think these factory methods are used, should they be?
| int result; | ||
| result = tryExecute(realRunnable); | ||
| final int result; | ||
| try (TryExecuteTask tryExecuteTask = POOLED_COMBINER_TASKS.get().on(this, realRunnable)) { |
There was a problem hiding this comment.
I wonder if something like #81 would allow us to avoid this threadlocal in favor of a couple additional references on an existing object?
|
I still don't fully understand the implementation, I'll need to stare at the code a bit longer. |
This is a kind of POC to improve performance of execute under heavy contention without modifying the original algorithm and assumptions.
@carterkozak @dmlloyd Feel free to both test and ask on the Zulipchat channel!!!