Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding/Updating Spanish Translations #1042

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ElijahMSmith
Copy link

Added many translations of string that were previously not given a Spanish translation.

Updated numerous translations with English words not translated or incorrect grammar/vocabulary.

@kurahaupo
Copy link
Collaborator

Thanks for that; it's always good to improve the user experience in their own language.

A request and a question:

  1. Can you please split the "fix build" commit into its own PR; the translations can still be accepted even if the build is failing.
  2. My knowledge of Spanish is rudimentary, but according to my friends from various south American countries, there's a fairly wide variation between countries in what's accepted as "normal vocabulary" for modern technology. Would it be worth splitting off separate translation files for es_ES, es_MX, es_AR, and es_US separate from generic es?

@ElijahMSmith
Copy link
Author

Oh lord. I'm so incredibly sorry for the reverts. By the time I realized my reverts were being committed, it was too late. If you couldn't tell, this is my first time doing any of this. I'd be more than happy to have this request closed and I'll open a new one with just the one commit for the strings.xml file.

Good to know about the build! I took the source from the master branch and didn't modify any of the files other than the strings file, and it didn't build on my end or on the test. The second commit was an attempt to fix some of the dependency issues it spat back at me.

To answer your second question: probably yes! I'm not a native speaker, but I've got 5 years of high school Spanish under my belt. I have absolutely no doubt that there's a large difference in vocabulary for each region. However, I couldn't even begin to differentiate that out myself. I think the app should certainly be usable for most Spanish speakers though as it is. The vocabulary that may differ between countries likely only makes up 1-2% of the text in the application.

I'll take a look into it though to see if there's anything I can find that could be improved!

@kurahaupo
Copy link
Collaborator

@ElijahMSmith you don't need to make a new PR for the actual translations, you can just adjust this one.

To start with, you can get rid of the reversions by going to your local repo and doing git rebase -i and then squash, or just git reset --hard 73fa433 you want to undo them all.

And then git push --force to update here on github.

If you have changes that aren't translations, you can make those in a separate branch, and make a new PR from that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants