Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deferred fields patch #1393

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

JordanHyatt
Copy link

@JordanHyatt JordanHyatt commented Sep 16, 2024

Description

Provided a patch that allows objects to be deleted when they have deferred fields present

Related Issue

This is related to issue #678

Motivation and Context

This allows users of simple_history to delete objects without having to consider the consequences of deferring fields in their query

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run the pre-commit run command to format and lint.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have added my name and/or github handle to AUTHORS.rst
  • I have added my change to CHANGES.rst
  • All new and existing tests passed.

@JordanHyatt
Copy link
Author

JordanHyatt commented Sep 16, 2024

I wanted to work on a new feature so I needed to branch my fork and re-submit this PR

@jwaschkau jwaschkau mentioned this pull request Sep 17, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant