Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct units in profiling.html and requests.html #725

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

ka28kumar
Copy link
Contributor

Fixes #115

Corrected the units from seconds to milliseconds.

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.36%. Comparing base (1cb4623) to head (f7677ae).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #725      +/-   ##
==========================================
+ Coverage   86.76%   87.36%   +0.60%     
==========================================
  Files          52       52              
  Lines        2115     2137      +22     
==========================================
+ Hits         1835     1867      +32     
+ Misses        280      270      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@albertyw albertyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also replace the other references to "seconds" in these files under placeholder and for timespentfilter with "milliseconds"?

@ka28kumar
Copy link
Contributor Author

Hello @albertyw
Updated other references. I'm unsure about filter-seconds-typ. Can you take a look and let me know if these changes suffice?

@albertyw albertyw merged commit dfb2826 into jazzband:master Aug 16, 2024
90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filters are in milliseconds but indicates seconds
2 participants