Refactor SQL query time calculation to use Django aggregation #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beltagymohamed
changed the title
albertyw
approved these changes
Jul 19, 2024
silk/models.py
Outdated
| @@ -124,16 +125,13 @@ def profile_table(self): | |||
|
|
|||
| @property | |||
| def time_spent_on_sql_queries(self): | |||
| """" | |||
| Calculate the total time spent in milli seconds on SQL queries using Django aggregates. | |||
There was a problem hiding this comment.
nit - "milliseconds" instead of "milli seconds"
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #720 +/- ##
==========================================
+ Coverage 86.76% 86.82% +0.05%
==========================================
Files 52 52
Lines 2115 2117 +2
==========================================
+ Hits 1835 1838 +3
+ Misses 280 279 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix a "FIXME" in the tests, and will make the code faster by utilizing db aggregation instead of python sum