Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SILKY_IGNORE_PATHS using path instead of path_info #577

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

djmango
Copy link

@djmango djmango commented Jul 1, 2022

Proposed solution in #349
@shimizukawa
@Korben11

@codecov
Copy link

codecov bot commented Jul 3, 2022

Codecov Report

Merging #577 (ee0812e) into master (5afcdea) will decrease coverage by 0.53%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #577      +/-   ##
==========================================
- Coverage   84.60%   84.07%   -0.54%     
==========================================
  Files          52       52              
  Lines        2072     2072              
==========================================
- Hits         1753     1742      -11     
- Misses        319      330      +11     
Impacted Files Coverage Δ
silk/middleware.py 89.42% <100.00%> (ø)
silk/utils/data_deletion.py 52.38% <0.00%> (-47.62%) ⬇️
silk/code_generation/django_test_client.py 65.21% <0.00%> (-4.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5afcdea...ee0812e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant