Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure correct compiler error styling and strip ANSI escape sequences. #810

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Ensure correct compiler error styling and strip ANSI escape sequences. #810

merged 2 commits into from
Apr 17, 2024

Commits on Apr 17, 2024

  1. Ensure correct compiler error styling and strip ANSI escape sequences. 

    The compiler error output that's injected into the page hard-codes a
background color of white, but didn't hard-code a corresponding text
color. If the page had set a default text color that was too close to
white, it would be hard or impossible to read without selecting the text
on the page.

This change addresses this by hard-coding a text color of black,
ensuring it can be read.

It also goes a step further and improves the display when dealing with
ANSI escape sequences in the error output, making it difficult to read
through or copy/paste meaningful results. We now apply a common regex
for stripping away any typical ANSI escape sequences we should expect in
such output, leaving behind only the plain text content.
    @chipx86
    chipx86 committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    d932cbe View commit details
    Browse the repository at this point in the history

  2. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    29cb731 View commit details
    Browse the repository at this point in the history