Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example Project + Translations for German #168

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

oesah
Copy link

@oesah oesah commented Feb 26, 2018

I added German translations and a simple example project that can be used out of the box. Let me know, if something needs improvement.

@codecov
Copy link

codecov bot commented Feb 26, 2018

Codecov Report

Merging #168 into master will increase coverage by 2.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
+ Coverage   79.12%   81.25%   +2.12%     
==========================================
  Files          27       26       -1     
  Lines        1648     1579      -69     
  Branches      190      187       -3     
==========================================
- Hits         1304     1283      -21     
+ Misses        245      192      -53     
- Partials       99      104       +5
Impacted Files Coverage Δ
payments/authorizenet/forms.py 86.36% <0%> (-8.24%) ⬇️
payments/urls.py
payments/authorizenet/__init__.py 86.11% <0%> (+6.56%) ⬆️
payments/wallet/widgets.py 100% <0%> (+47.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db6279d...292e5be. Read the comment docs.

@patrys
Copy link
Contributor

patrys commented Feb 26, 2018

Would you mind contributing the translations through Transifex? We synchronize the translation files in the repository every couple of days and it would overwrite your changes.

@oesah
Copy link
Author

oesah commented Feb 27, 2018

I joined the group, not sure how it works yet, I'm new to that tool. But I can add / review the translations, if you like.

@RedBeardCode
Copy link

+1

@Alir3z4
Copy link

Alir3z4 commented Jul 8, 2018

The example project is really good and helpful.
The translation provided can be added to the project and then pushed to transifex without needing @oesah to duplicate on transifex.

Any idea when this will be merged ?

@creyD
Copy link

creyD commented Apr 6, 2020

@oesah As far as I understand this translation was now submitted through Transifex? Can we close this PR then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants