refactor timex logic into its own utils module

jarlah · Oct 3, 2024 · cddc452 · cddc452
1 parent 6d982e2
commit cddc452
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 26 deletions.
diff --git a/lib/journi_plan/itineraries/projectors/activity.ex b/lib/journi_plan/itineraries/projectors/activity.ex
@@ -9,24 +9,22 @@ defmodule JourniPlan.Itineraries.Projectors.Activity do
 
   import  JourniPlan.Utils.UUID
 
-  alias JourniPlan.Itineraries.Events.ActivityCreated
-  alias JourniPlan.Itineraries.Events.ActivityNameUpdated
-  alias JourniPlan.Itineraries.Events.ActivityDescriptionUpdated
-  alias JourniPlan.Itineraries.Events.ActivityStartTimeUpdated
-  alias JourniPlan.Itineraries.Events.ActivityEndTimeUpdated
-  alias JourniPlan.Itineraries.Events.ActivityDeleted
+  alias JourniPlan.Itineraries.Events.{
+    ActivityCreated,
+    ActivityNameUpdated,
+    ActivityDescriptionUpdated,
+    ActivityStartTimeUpdated,
+    ActivityEndTimeUpdated,
+    ActivityDeleted
+  }
 
   alias JourniPlan.Itineraries.Projections.Activity
 
+  import JourniPlan.TimexUtils, only: [parse_to_datetime!: 1]
+
   project(%ActivityCreated{} = created, _, fn multi ->
-    start_time =
-      created.start_time
-      |> Timex.parse!("%Y-%m-%dT%H:%M", :strftime)
-      |> Timex.to_datetime("Etc/UTC")
-    end_time =
-      created.end_time
-      |> Timex.parse!("%Y-%m-%dT%H:%M", :strftime)
-      |> Timex.to_datetime("Etc/UTC")
+    start_time = parse_to_datetime!(created.start_time)
+    end_time = parse_to_datetime!(created.end_time)
     itinerary_uuid = cast_uuid!(created.itinerary_uuid)
 
     Ecto.Multi.insert(multi, :activity, %Activity{

diff --git a/lib/journi_plan/itineraries/projectors/itinerary.ex b/lib/journi_plan/itineraries/projectors/itinerary.ex
@@ -7,10 +7,12 @@ defmodule JourniPlan.Itineraries.Projectors.Itinerary do
 
   alias JourniPlan.Repo
 
-  alias JourniPlan.Itineraries.Events.ItineraryCreated
-  alias JourniPlan.Itineraries.Events.ItineraryNameUpdated
-  alias JourniPlan.Itineraries.Events.ItineraryDescriptionUpdated
-  alias JourniPlan.Itineraries.Events.ItineraryDeleted
+  alias JourniPlan.Itineraries.Events.{
+    ItineraryCreated,
+    ItineraryNameUpdated,
+    ItineraryDescriptionUpdated,
+    ItineraryDeleted
+  }
 
   alias JourniPlan.Itineraries.Projections.Itinerary
 

diff --git a/lib/journi_plan/itineraries/projectors/journal_entry.ex b/lib/journi_plan/itineraries/projectors/journal_entry.ex
@@ -9,18 +9,19 @@ defmodule JourniPlan.Itineraries.Projectors.JournalEntry do
 
   import  JourniPlan.Utils.UUID
 
-  alias JourniPlan.Itineraries.Events.JournalEntryCreated
-  alias JourniPlan.Itineraries.Events.JournalEntryTitleUpdated
-  alias JourniPlan.Itineraries.Events.JournalEntryBodyUpdated
-  alias JourniPlan.Itineraries.Events.JournalEntryDeleted
+  alias JourniPlan.Itineraries.Events.{
+    JournalEntryCreated,
+    JournalEntryTitleUpdated,
+    JournalEntryBodyUpdated,
+    JournalEntryDeleted
+  }
 
   alias JourniPlan.Itineraries.Projections.JournalEntry
 
+  import JourniPlan.TimexUtils, only: [parse_to_datetime!: 1]
+
   project(%JournalEntryCreated{} = created, _, fn multi ->
-    entry_date =
-      created.entry_date
-      |> Timex.parse!("%Y-%m-%dT%H:%M", :strftime)
-      |> Timex.to_datetime("Etc/UTC")
+    entry_date = parse_to_datetime!(created.entry_date)
     itinerary_uuid = cast_uuid!(created.itinerary_uuid)
     activity_uuid = cast_uuid!(created.activity_uuid)
 

diff --git a/lib/journi_plan/utils/timex.ex b/lib/journi_plan/utils/timex.ex
@@ -0,0 +1,7 @@
+defmodule JourniPlan.TimexUtils do
+  def parse_to_datetime!(time) when is_binary(time) do
+    time
+      |> Timex.parse!("%Y-%m-%dT%H:%M", :strftime)
+      |> Timex.to_datetime("Etc/UTC")
+  end
+end