Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for UUID in User Table, and Laravel 9 support #17

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

lrljoe
Copy link

@lrljoe lrljoe commented Jun 20, 2022

No description provided.

@lrljoe
Copy link
Author

lrljoe commented Jan 16, 2023

@jamesmills are you still maintaining this?

@jamesmills
Copy link
Owner

@lrljoe if we update the swap the bigInteger to uuid for the user_id on the watch_table then we're going to break everything aren't we?

$table->bigInteger('user_id')->unsigned()->index();
$table->uuid('user_id')->index();

@jamesmills
Copy link
Owner

@jamesmills are you still maintaining this?

I guess so, I'm not using it in any of my own projects any more.

@lrljoe
Copy link
Author

lrljoe commented Feb 19, 2023

@lrljoe if we update the swap the bigInteger to uuid for the user_id on the watch_table then we're going to break everything aren't we?

$table->bigInteger('user_id')->unsigned()->index();
$table->uuid('user_id')->index();

Errr shouldn't do (I think)? I use uuids in my fork as well as multiple user models, I'll spin up a variant tomorrow and see how broken it is with a normal bitInteger approach

@lrljoe
Copy link
Author

lrljoe commented Oct 31, 2023

Will do a re-review of this in the next month or so, make sure that I'm not breaking anything, then update you @jamesmills

Appreciate you're not using it any more, I'll do the relevant tests on my end to make sure it doesn't break anything. If it's non-breaking change, then happy to help maintain going forward as much as you want/need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants