-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clone jpa tests into jpa-tck folder Restore the jpa-platform test usage of the ServiceEETest class + prepare for generating new EE TCK tests #1442
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Scott Marlow <[email protected]>
…m.xml Signed-off-by: Scott Marlow <[email protected]>
…class prefix from non-client classes. Signed-off-by: Scott Marlow <[email protected]>
Signed-off-by: Scott Marlow <[email protected]>
Signed-off-by: Scott Marlow <[email protected]>
Signed-off-by: Scott Marlow <[email protected]>
Signed-off-by: Scott Marlow <[email protected]>
6cb260c
to
84fa3c2
Compare
Just pushed an update to resolve a merge conflict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- consider adding some readme saying which tck it actually is into each folder
- consider add
-SNAPSHOT
to the platform version to denote work in progress
it's a pity that one cannot copy&paste just a subset of tests which are relevant for the platform (jakartaee/jakarta.ee#1813)
Should already be 11.0.0-SNAPSHOT unless we missed updating a pom.xml, will check
One idea was to update the already balloted Persistence 3.2 https://github.com/scottmarlow/jakartaee-tck/blob/jpa_jpa-tck_prepareformerge/jpa-tck/common/src/main/java/ee/jakarta/tck/persistence/common/PMClientBase.java to extend the ServiceEETest class like https://github.com/scottmarlow/jakartaee-tck/blob/jpa_jpa-tck_prepareformerge/jpa/common/src/main/java/ee/jakarta/tck/persistence/common/PMClientBase.java does with logger changes. Tests would also need logger changes as well which we did make to the jpa/common/src + jpa-tck/common/src are exactly the same (no changes made). |
#1418
jpa-tck
folder is the Standalone Persistence TCK tests and thejpa
folder will be the Platform TCK Persistence tests.CC @lukasj
Locally, after this is merged, I will switch to using latest https://github.com/eclipse-ee4j/jakartaee-tck-tools snapshot build.
CC @alwin-joseph @anajosep @arjantijms @cesarhernandezgt @dblevins @m0mus @edbratt @gurunrao @jansupol @jgallimore @kazumura @kwsutter @LanceAndersen @bhatpmk @RohitKumarJain @shighbar @gthoman @brideck @OndroMih @dmatej
@starksm64 @scottmarlow