-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove finalize() #725
base: master
Are you sure you want to change the base?
Remove finalize() #725
Conversation
Signed-off-by: Jorge Bescos Gascon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jbescos You can feel free to notify me or add me as a reviewer if you want me to look at something. I missed this one because I forgot to check for new PRs.
Also more of housekeeping thing but, I didn't create a clone issue in angus mail. There are finializers there too that need to be removed. I'm not sure of the workflow but I noticed that it is possible to:
The result is one less issue ticket being created without any numbering conflicts. |
Signed-off-by: Jorge Bescos Gascon <[email protected]>
Signed-off-by: Jorge Bescos Gascon <[email protected]>
Signed-off-by: Jorge Bescos Gascon <[email protected]>
Signed-off-by: Jorge Bescos Gascon <[email protected]>
Signed-off-by: Jorge Bescos Gascon <[email protected]>
Signed-off-by: Jorge Bescos Gascon <[email protected]>
@@ -32,6 +32,7 @@ | |||
import java.util.List; | |||
import java.util.Vector; | |||
import java.util.concurrent.Executor; | |||
import java.util.concurrent.atomic.AtomicBoolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dead import?
Signed-off-by: Jorge Bescos Gascon <[email protected]>
Signed-off-by: Jorge Bescos Gascon <[email protected]>
Before I forget, you'll have to write up some COMPAT.txt notes for close:
Understand that this is blocked by version changes and PR is still draft so there could be more. |
#720
I found only few places in mail-api. Some of them are abstract and they don't have usage in mail-api, so I will need to check angus-mail.
It is probably out of the scope of this issue, but I couldn't resist to remove
Objects.requireNonNull(this);
. Is there any reason to have that?.