Prepare release 1.62.0 / 2.0.0-rc2 #6057
Conversation
albertteoh
commented
Oct 6, 2024
•
albertteoh
commented
- TODO: @albertteoh bump jaeger-ui submodule when Prepare release v1.62.0 jaeger-ui#2463 is merged and new release is tagged.
Signed-off-by: albertteoh <[email protected]>
Signed-off-by: albertteoh <[email protected]>
|
albertteoh
added
the
changelog:skip
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6057 +/- ##
=======================================
Coverage 96.90% 96.90%
=======================================
Files 349 349
Lines 16588 16588
=======================================
Hits 16075 16075
Misses 329 329
Partials 184 184
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
scripts/release-notes.py
Outdated
| @@ -97,7 +97,7 @@ def main(token, repo, branch, num_commits, exclude_dependabot, verbose): | |||
|
|
|||
| progress_iterator = 0 | |||
| for commit in commits: | |||
| if verbose: | |||
| if repo == 'jaeger': | |||
There was a problem hiding this comment.
this is rather odd - why do you only want progress reporting for one specific repo?
There was a problem hiding this comment.
It's equivalent to what we had before. In jaeger Makefile, we had --verbose set for changelog target, then it's disabled for the jaeger-ui repo to prevent progress from showing for the jaeger-ui section.
The reason for doing this is because we shouldn't need to use --verbose flag by default and it should be respected for both jaeger and jaeger-ui repos. Either way, it's not ideal, but I think it's better if --verbose was respected irrespective of the repo.
There was a problem hiding this comment.
Hmmm... actually, it's a good callout. I just realised we're using the same script for jaeger-ui. I'll revert this change in that case.
tip: include these in the main description, this way GitHub shows "remaining tasks" in the PR header: 
|
Co-authored-by: Yuri Shkuro <[email protected]> Signed-off-by: Albert <[email protected]>
Signed-off-by: Albert Teoh <[email protected]>
Signed-off-by: Albert Teoh <[email protected]>
Signed-off-by: Albert Teoh <[email protected]>
## Which problem is this PR solving? - Part of jaegertracing#6040 ## Description of the changes - Added the [attributesprocessor](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/processor/attributesprocessor/README.md) to the Jaeger V2 binary to replace `--collector.tags`. See the [migration guide](https://docs.google.com/document/d/18B1yTMewRft2N0nW9K-ecVRTt5VaNgnrPTW1eL236t4/edit?usp=sharing) for more details. ## How was this change tested? - ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Mahad Zaryab <[email protected]>
Yup, thanks! Sorry it took a bit longer because I had to fix the draft-release script which was broken for jaeger-ui. The fix and UI submodule update is in: 225ba26 |
