Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove not needed GetAddressFromCLIOptions #5742

Merged

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

  • Remove function that is no longer needed

@yurishkuro yurishkuro requested a review from a team as a code owner July 14, 2024 03:28
@yurishkuro yurishkuro added the changelog:skip Trivial change that does not require an entry in CHANGELOG label Jul 14, 2024
Copy link

codecov bot commented Jul 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.85%. Comparing base (e3e763c) to head (5d94ab2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5742      +/-   ##
==========================================
+ Coverage   96.84%   96.85%   +0.01%     
==========================================
  Files         335      335              
  Lines       16166    16162       -4     
==========================================
- Hits        15656    15654       -2     
+ Misses        340      339       -1     
+ Partials      170      169       -1     
Flag Coverage Δ
badger_v1 8.05% <ø> (+<0.01%) ⬆️
badger_v2 1.90% <ø> (+<0.01%) ⬆️
cassandra-3.x-v1 16.61% <ø> (+<0.01%) ⬆️
cassandra-3.x-v2 1.82% <ø> (+<0.01%) ⬆️
cassandra-4.x-v1 16.61% <ø> (+<0.01%) ⬆️
cassandra-4.x-v2 1.82% <ø> (+<0.01%) ⬆️
elasticsearch-6.x-v1 18.77% <ø> (-0.01%) ⬇️
elasticsearch-7.x-v1 18.84% <ø> (+0.02%) ⬆️
elasticsearch-8.x-v1 19.02% <ø> (-0.01%) ⬇️
elasticsearch-8.x-v2 1.88% <ø> (-0.02%) ⬇️
grpc_v1 9.51% <ø> (-0.01%) ⬇️
grpc_v2 7.48% <ø> (+<0.01%) ⬆️
kafka 9.74% <ø> (+<0.01%) ⬆️
opensearch-1.x-v1 18.88% <ø> (-0.01%) ⬇️
opensearch-2.x-v1 18.89% <ø> (+<0.01%) ⬆️
opensearch-2.x-v2 1.90% <ø> (+0.01%) ⬆️
unittests 95.24% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit 882ae45 into jaegertracing:main Jul 14, 2024
43 checks passed
@yurishkuro yurishkuro deleted the remove-GetAddressFromCLIOptions branch July 14, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:skip Trivial change that does not require an entry in CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants