Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release 1.56.0 #5321

Merged
merged 3 commits into from
Apr 3, 2024
Merged

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Apr 2, 2024

  • coincidentally GitHub runners removed docker-compose (v1) command on Apr-1, so I added a commit that changes everything to use docker compose (v2)
  • the all-in-one integration tests were failing because jaeger logo file in ui static assets got a different hash for some reason. I changed the test to read the actual file name from index.html and then try to load it.

Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro added the changelog:skip Trivial change that does not require an entry in CHANGELOG label Apr 2, 2024
@yurishkuro yurishkuro requested a review from a team as a code owner April 2, 2024 22:41
@yurishkuro yurishkuro requested a review from jkowall April 2, 2024 22:41
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.15%. Comparing base (055fcd7) to head (b3e8eae).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5321      +/-   ##
==========================================
- Coverage   95.16%   95.15%   -0.02%     
==========================================
  Files         340      340              
  Lines       16666    16666              
==========================================
- Hits        15860    15858       -2     
- Misses        616      617       +1     
- Partials      190      191       +1     
Flag Coverage Δ
badger 12.25% <ø> (ø)
cassandra-3.x 21.14% <ø> (ø)
cassandra-4.x 21.14% <ø> (ø)
elasticsearch-5.x 17.70% <ø> (ø)
elasticsearch-6.x 17.70% <ø> (ø)
elasticsearch-7.x 17.75% <ø> (ø)
elasticsearch-8.x 17.83% <ø> (ø)
grpc 11.59% <ø> (ø)
kafka 11.84% <ø> (ø)
opensearch-1.x 17.75% <ø> (ø)
opensearch-2.x 17.76% <ø> (+0.01%) ⬆️
unittests 92.33% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jkowall jkowall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for fixing the version next to my name too!

@yurishkuro yurishkuro merged commit ecbae67 into jaegertracing:main Apr 3, 2024
37 checks passed
@yurishkuro yurishkuro deleted the prep-rel-1.56.0 branch April 3, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:skip Trivial change that does not require an entry in CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants