Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] set the passedin rackid properly in consumer config #5275

Closed
wants to merge 6 commits into from
Closed

[bug] set the passedin rackid properly in consumer config #5275

wants to merge 6 commits into from

Conversation

sappusaketh
Copy link
Contributor

@sappusaketh sappusaketh commented Mar 15, 2024 •
edited
Loading

Which problem is this PR solving?

RackID option was exposed in this PR but it was not properly parsed from passed flags and set on Sarama client

Description of the changes

  • configures Parsed RackID on ConsumerConfig
  • Fix failing lint issues

How was this change tested?

  • Tested by printing the config passed to sarama client

Checklist

@sappusaketh sappusaketh requested a review from a team as a code owner March 15, 2024 01:13
@sappusaketh
fix merge conflicts
1585a7b 
Signed-off-by: Saketh kappala <[email protected]>
@sappusaketh
fix merge conflicts
8c89a78 
Signed-off-by: Saketh kappala <[email protected]>
@sappusaketh
fix merge conflicts
505c92f 
Signed-off-by: Saketh kappala <[email protected]>
@sappusaketh sappusaketh closed this by deleting the head repository Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-elliott joe-elliott Awaiting requested review from joe-elliott joe-elliott is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sappusaketh