Replace OpenTracing instrumentation with OpenTelemetry in grpc storage plugin #4611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4611 +/- ##
==========================================
+ Coverage 97.07% 97.09% +0.01%
==========================================
Files 301 301
Lines 17870 17878 +8
==========================================
+ Hits 17347 17358 +11
+ Misses 419 417 -2
+ Partials 104 103 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: Afzal <[email protected]>
afzalbin64
force-pushed
the
replace-otgprc-with-otelgrpc
branch
from
5dab3d6
to
1533288
Compare
albertteoh
previously approved these changes
Aug 3, 2023
yurishkuro
reviewed
Aug 3, 2023
Signed-off-by: Afzal <[email protected]>
afzalbin64
reviewed
Aug 4, 2023
Signed-off-by: Afzal <[email protected]>
afzalbin64
force-pushed
the
replace-otgprc-with-otelgrpc
branch
from
6bfb008
to
c18927f
Compare
yurishkuro
approved these changes
Aug 4, 2023
yurishkuro
changed the title
otgrpc plugin storage with otel grpc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
otelgrpcplugin to storageShort description of the changes
otgrpcplugin storage with otel grpc interceptors