[tracegen] Enable OTEL debug logging #4571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <[email protected]>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #4571 +/- ##
=======================================
Coverage 97.04% 97.05%
=======================================
Files 301 301
Lines 17817 17837 +20
=======================================
+ Hits 17291 17312 +21
+ Misses 422 421 -1
Partials 104 104
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
afzal442
pushed a commit
to Cloud-Hacks/jaeger
that referenced
this pull request
Jul 10, 2023
## Which problem is this PR solving?
- Unlike Jaeger Go SDK, OTEL OTLP exporter does not provide good
observability into how much trace data is being produced / exported /
dropped
## Short description of the changes
- Connect OTEL logger to Zap logger and allow Debug() level, which is
used by OTLP exporter to log stats like this:
```
2023-07-06T13:05:07.688-0400 LEVEL(-8) global/internal_logging.go:63 exporting spans {"count": 2, "total_dropped": 0}
```
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Afzal Ansari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes