Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jaeger-v2] Refactor ElasticSearch/OpenSearch Storage Configurations #6059

Open
2 of 6 tasks
mahadzaryab1 opened this issue Oct 6, 2024 · 2 comments
Open
2 of 6 tasks

[jaeger-v2] Refactor ElasticSearch/OpenSearch Storage Configurations #6059

mahadzaryab1 opened this issue Oct 6, 2024 · 2 comments
Labels
area/otel area/storage enhancement storage/elasticsearch v2

Comments

@mahadzaryab1
Copy link
Contributor

mahadzaryab1 commented Oct 6, 2024 •
edited
Loading

Requirement

In this issue, we want to align the configuration for elastic search and open search storage with OTEL (part of #5229)

Problem

  • All config fields are tagged with mapstructure such that they can be addressable from YAML via "good" names
  • Configs implement Validate()
  • Configs via YAML support the same defaults as in jaeger-v1
  • Configs reuse standard elements of OTEL configs whenever possible, e.g. TLS, clientcfg, etc.
  • Configuration looks "logical" and properly grouped, not flattened with long weird names
  • We create a migration guide document with a table that lists v1 CLI flags and the corresponding v2 config fields
@mahadzaryab1 mahadzaryab1 mentioned this issue Oct 6, 2024
Merged
4 tasks
@mahadzaryab1
Copy link
Contributor Author

@yurishkuro is a migration guide needed here?

@mahadzaryab1 mahadzaryab1 mentioned this issue Oct 6, 2024
Closed
@yurishkuro
Copy link
Member

yes, certainly

@yurishkuro yurishkuro mentioned this issue Oct 6, 2024
Open
16 tasks
yurishkuro added a commit that referenced this issue Oct 12, 2024
@mahadzaryab1 @JaredTan95 @yurishkuro
[jaeger-v2] Refactor ElasticSearch/OpenSearch Storage Configurations (#…
563f3b0 
…6060)

## Which problem is this PR solving?
- Part of #6059

## Description of the changes
- Continuation of #5790
- Refactors the configurations for ElasticSearch and OpenSearch to
simplify the configuration by having more logical groupings

## How was this change tested?
- Unit Tests and E2E Integration Tests

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

---------

Signed-off-by: Jared Tan <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Co-authored-by: Jared Tan <[email protected]>
Co-authored-by: Yuri Shkuro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/otel area/storage enhancement storage/elasticsearch v2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yurishkuro @mahadzaryab1