Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jaeger-v2] Refactor ElasticSearch/OpenSearch Storage Configurations #6060

Merged
merged 45 commits into from
Oct 12, 2024

Conversation

mahadzaryab1
Copy link
Contributor

@mahadzaryab1 mahadzaryab1 commented Oct 6, 2024

Which problem is this PR solving?

Description of the changes

How was this change tested?

  • Unit Tests and E2E Integration Tests

Checklist

Copy link

codecov bot commented Oct 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.91%. Comparing base (b2f8be2) to head (bfd0f93).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6060      +/-   ##
==========================================
- Coverage   96.92%   96.91%   -0.01%     
==========================================
  Files         349      349              
  Lines       16598    16646      +48     
==========================================
+ Hits        16087    16133      +46     
- Misses        328      329       +1     
- Partials      183      184       +1     
Flag Coverage Δ
badger_v1 7.98% <0.00%> (-0.01%) ⬇️
badger_v2 1.84% <0.00%> (+0.02%) ⬆️
cassandra-4.x-v1 15.75% <0.00%> (-0.04%) ⬇️
cassandra-4.x-v2 1.77% <0.00%> (+0.02%) ⬆️
cassandra-5.x-v1 15.75% <0.00%> (-0.04%) ⬇️
cassandra-5.x-v2 1.77% <0.00%> (+0.02%) ⬆️
elasticsearch-6.x-v1 18.95% <86.24%> (+0.25%) ⬆️
elasticsearch-7.x-v1 19.01% <86.24%> (+0.26%) ⬆️
elasticsearch-8.x-v1 19.20% <86.24%> (+0.25%) ⬆️
elasticsearch-8.x-v2 1.83% <0.00%> (+0.01%) ⬆️
grpc_v1 9.35% <0.00%> (-0.03%) ⬇️
grpc_v2 7.12% <0.00%> (+<0.01%) ⬆️
kafka-v1 9.68% <0.00%> (-0.02%) ⬇️
kafka-v2 1.84% <0.00%> (+0.02%) ⬆️
memory_v2 1.84% <0.00%> (+0.02%) ⬆️
opensearch-1.x-v1 19.06% <86.24%> (+0.26%) ⬆️
opensearch-2.x-v1 19.05% <86.24%> (+0.24%) ⬆️
opensearch-2.x-v2 1.83% <0.00%> (+0.01%) ⬆️
tailsampling-processor 0.49% <0.00%> (+0.03%) ⬆️
unittests 95.72% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

JaredTan95 and others added 10 commits October 6, 2024 10:48
Signed-off-by: Jared Tan <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Jared Tan <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Jared Tan <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Jared Tan <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
pkg/es/config/config.go Outdated Show resolved Hide resolved
pkg/es/config/config.go Outdated Show resolved Hide resolved
@mahadzaryab1 mahadzaryab1 changed the title [WIP] Refactor ElasticSearch/OpenSearch Storage Configurations Refactor ElasticSearch/OpenSearch Storage Configurations Oct 6, 2024
@mahadzaryab1 mahadzaryab1 marked this pull request as ready for review October 6, 2024 15:44
@mahadzaryab1 mahadzaryab1 requested a review from a team as a code owner October 6, 2024 15:44
@yurishkuro yurishkuro added the changelog:exprimental Change to an experimental part of the code label Oct 6, 2024
Signed-off-by: Mahad Zaryab <[email protected]>
@mahadzaryab1
Copy link
Contributor Author

@yurishkuro
Copy link
Member

regarding #5790 (comment), are you referring to https://github.com/jaegertracing/jaeger/blob/main/plugin/storage/es/factory.go#L196-L210?

yes

@yurishkuro yurishkuro merged commit 563f3b0 into jaegertracing:main Oct 12, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:exprimental Change to an experimental part of the code storage/elasticsearch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants