Skip to content

Commit

Permalink
Enable Query Metrics for V2
Browse files Browse the repository at this point in the history
Signed-off-by: Wise-Wizard <[email protected]>
  • Loading branch information
Wise-Wizard committed Jul 23, 2024
1 parent 495577a commit f410b06
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions cmd/jaeger/internal/extension/jaegerquery/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,13 @@ import (
"github.com/jaegertracing/jaeger/cmd/jaeger/internal/extension/jaegerstorage"
queryApp "github.com/jaegertracing/jaeger/cmd/query/app"
"github.com/jaegertracing/jaeger/cmd/query/app/querysvc"
"github.com/jaegertracing/jaeger/internal/metrics/otelmetrics"
"github.com/jaegertracing/jaeger/pkg/jtracer"
"github.com/jaegertracing/jaeger/pkg/metrics"
"github.com/jaegertracing/jaeger/pkg/telemetery"
"github.com/jaegertracing/jaeger/pkg/tenancy"
"github.com/jaegertracing/jaeger/plugin/metrics/disabled"
storageMetrics "github.com/jaegertracing/jaeger/storage/spanstore/metrics"
)

var (
Expand Down Expand Up @@ -45,6 +48,8 @@ func (*server) Dependencies() []component.ID {
}

func (s *server) Start(_ context.Context, host component.Host) error {
mf := otelmetrics.NewFactory(s.telset.MeterProvider)
queryMetricsFactory := mf.Namespace(metrics.NSOptions{Name: "query"})
f, err := jaegerstorage.GetStorageFactory(s.config.TraceStoragePrimary, host)
if err != nil {
return fmt.Errorf("cannot find primary storage %s: %w", s.config.TraceStoragePrimary, err)
Expand All @@ -54,8 +59,8 @@ func (s *server) Start(_ context.Context, host component.Host) error {
if err != nil {
return fmt.Errorf("cannot create span reader: %w", err)
}
// TODO
// spanReader = storageMetrics.NewReadMetricsDecorator(spanReader, baseFactory.Namespace(metrics.NSOptions{Name: "query"}))

spanReader = storageMetrics.NewReadMetricsDecorator(spanReader, queryMetricsFactory)

depReader, err := f.CreateDependencyReader()
if err != nil {
Expand All @@ -81,6 +86,7 @@ func (s *server) Start(_ context.Context, host component.Host) error {
telset := telemetery.Setting{
Logger: s.telset.Logger,
TracerProvider: tracerProvider.OTEL,
Metrics: queryMetricsFactory,
ReportStatus: s.telset.ReportStatus,
}

Expand Down

0 comments on commit f410b06

Please sign in to comment.