Skip to content

Commit

Permalink
Reverted Changes
Browse files Browse the repository at this point in the history
Signed-off-by: Wise-Wizard <[email protected]>
  • Loading branch information
Wise-Wizard committed Jul 21, 2024
1 parent 885c057 commit eedb4c5
Show file tree
Hide file tree
Showing 2 changed files with 33 additions and 14 deletions.
17 changes: 9 additions & 8 deletions cmd/jaeger/internal/all-in-one.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,15 @@ service:
service.name: jaeger
metrics:
level: detailed
traces:
processors:
- batch:
schedule_delay: 1000
exporter:
otlp:
endpoint: http://localhost:4318
protocol: http/protobuf
# TODO Initialize telemetery tracer once OTEL released new feature.
# traces:
# processors:
# - batch:
# schedule_delay: 1000
# exporter:
# otlp:
# endpoint: http://localhost:4318
# protocol: http/protobuf
extensions:
jaeger_query:
trace_storage: some_storage
Expand Down
30 changes: 24 additions & 6 deletions cmd/jaeger/internal/extension/jaegerquery/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ package jaegerquery

import (
"context"
"errors"
"fmt"

"go.opentelemetry.io/collector/component"
Expand All @@ -13,6 +14,7 @@ import (
"github.com/jaegertracing/jaeger/cmd/jaeger/internal/extension/jaegerstorage"
queryApp "github.com/jaegertracing/jaeger/cmd/query/app"
"github.com/jaegertracing/jaeger/cmd/query/app/querysvc"
"github.com/jaegertracing/jaeger/pkg/jtracer"
"github.com/jaegertracing/jaeger/pkg/telemetery"
"github.com/jaegertracing/jaeger/pkg/tenancy"
"github.com/jaegertracing/jaeger/plugin/metrics/disabled"
Expand All @@ -24,9 +26,10 @@ var (
)

type server struct {
config *Config
server *queryApp.Server
telset component.TelemetrySettings
config *Config
server *queryApp.Server
telset component.TelemetrySettings
closeTracer func(ctx context.Context) error
}

func newServer(config *Config, otel component.TelemetrySettings) *server {
Expand Down Expand Up @@ -67,9 +70,17 @@ func (s *server) Start(_ context.Context, host component.Host) error {
metricsQueryService, _ := disabled.NewMetricsReader()
tm := tenancy.NewManager(&s.config.Tenancy)

// TODO OTel-collector does not initialize the tracer currently
// https://github.com/open-telemetry/opentelemetry-collector/issues/7532
//nolint
tracerProvider, err := jtracer.New("jaeger")
if err != nil {
return fmt.Errorf("could not initialize a tracer: %w", err)
}
s.closeTracer = tracerProvider.Close
telset := telemetery.Setting{
Logger: s.telset.Logger,
TracerProvider: s.telset.TracerProvider,
TracerProvider: tracerProvider.OTEL,
ReportStatus: s.telset.ReportStatus,
}

Expand Down Expand Up @@ -122,6 +133,13 @@ func (s *server) makeQueryOptions() *queryApp.QueryOptions {
}
}

func (s *server) Shutdown(_ context.Context) error {
return s.server.Close()
func (s *server) Shutdown(ctx context.Context) error {
var errs []error
if s.server != nil {
errs = append(errs, s.server.Close())
}
if s.closeTracer != nil {
errs = append(errs, s.closeTracer(ctx))
}
return errors.Join(errs...)
}

0 comments on commit eedb4c5

Please sign in to comment.