Skip to content

Commit

Permalink
[chore] Remove direct dependency on jaeger-lib (#4721)
Browse files Browse the repository at this point in the history
## Which problem is this PR solving?
- Part of #3381

## Description of the changes
- Remove internal unused package `jlibadapter`
- Remove unnecessary dependency on jaeger-lib in the tests

## How was this change tested?
- Unit tests

Signed-off-by: Yuri Shkuro <[email protected]>
  • Loading branch information
yurishkuro authored Sep 4, 2023
1 parent ecffad7 commit a49a164
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 114 deletions.
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ require (
github.com/spf13/viper v1.16.0
github.com/stretchr/testify v1.8.4
github.com/uber/jaeger-client-go v2.30.0+incompatible
github.com/uber/jaeger-lib v2.4.1+incompatible
github.com/xdg-go/scram v1.1.2
go.opentelemetry.io/collector/component v0.84.0
go.opentelemetry.io/collector/config/configgrpc v0.84.0
Expand Down Expand Up @@ -151,6 +150,7 @@ require (
github.com/spf13/jwalterweatherman v1.1.0 // indirect
github.com/stretchr/objx v0.5.0 // indirect
github.com/subosito/gotenv v1.4.2 // indirect
github.com/uber/jaeger-lib v2.4.1+incompatible // indirect
github.com/xdg-go/pbkdf2 v1.0.0 // indirect
github.com/xdg-go/stringprep v1.0.4 // indirect
go.mongodb.org/mongo-driver v1.11.6 // indirect
Expand Down
2 changes: 1 addition & 1 deletion internal/metrics/expvar/metrics_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ import (

"github.com/go-kit/kit/metrics/generic"
"github.com/stretchr/testify/assert"
"github.com/uber/jaeger-lib/metrics"

"github.com/jaegertracing/jaeger/internal/metrics/expvar"
"github.com/jaegertracing/jaeger/pkg/metrics"
)

func TestCounter(t *testing.T) {
Expand Down
80 changes: 0 additions & 80 deletions internal/metrics/jlibadapter/adapter.go

This file was deleted.

32 changes: 0 additions & 32 deletions internal/metrics/jlibadapter/adapter_test.go

This file was deleted.

0 comments on commit a49a164

Please sign in to comment.