Skip to content

Commit

Permalink
[v2] Replace e2e span_reader grpc.DialContext with NewClient (#5443)
Browse files Browse the repository at this point in the history
  • Loading branch information
james-ryans authored May 12, 2024
1 parent a2a9188 commit 5757c56
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions cmd/jaeger/internal/integration/span_reader.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import (
"io"
"math"
"strings"
"time"

"google.golang.org/grpc"
"google.golang.org/grpc/credentials/insecure"
Expand Down Expand Up @@ -39,10 +38,7 @@ func createSpanReader(port int) (*spanReader, error) {
grpc.WithTransportCredentials(insecure.NewCredentials()),
}

ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
defer cancel()

cc, err := grpc.DialContext(ctx, ports.PortToHostPort(port), opts...)
cc, err := grpc.NewClient(ports.PortToHostPort(port), opts...)
if err != nil {
return nil, err
}
Expand Down

0 comments on commit 5757c56

Please sign in to comment.