Skip to content

Commit

Permalink
Strip otelcol prefix while comparing metrics
Browse files Browse the repository at this point in the history
Signed-off-by: Wise-Wizard <[email protected]>
  • Loading branch information
Wise-Wizard committed Jul 30, 2024
1 parent e53e74a commit 1c080d1
Showing 1 changed file with 8 additions and 9 deletions.
17 changes: 8 additions & 9 deletions scripts/compare_metrics.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

import json

# Load the JSON files
v1_metrics_path = "./V1_Metrics.json"
v2_metrics_path = "./V2_Metrics.json"

Expand All @@ -17,18 +16,22 @@
v2_metrics = json.load(file)

# Extract names and labels of the metrics
def extract_metrics_with_labels(metrics):
def extract_metrics_with_labels(metrics, strip_prefix=None):
result = {}
for metric in metrics:
name = metric['name']
if strip_prefix and name.startswith(strip_prefix):
name = name[len(strip_prefix):]
labels = {}
if 'metrics' in metric and 'labels' in metric['metrics'][0]:
labels = metric['metrics'][0]['labels']
result[name] = labels
return result


v1_metrics_with_labels = extract_metrics_with_labels(v1_metrics)
v2_metrics_with_labels = extract_metrics_with_labels(v2_metrics)
v2_metrics_with_labels = extract_metrics_with_labels(
v2_metrics, strip_prefix="otelcol_")

# Compare the metrics names and labels
common_metrics = {}
Expand All @@ -37,10 +40,7 @@ def extract_metrics_with_labels(metrics):

for name, labels in v1_metrics_with_labels.items():
if name in v2_metrics_with_labels:
if labels == v2_metrics_with_labels[name]:
common_metrics[name] = labels
else:
v1_only_metrics[name] = labels
common_metrics[name] = labels
else:
v1_only_metrics[name] = labels

Expand All @@ -54,9 +54,8 @@ def extract_metrics_with_labels(metrics):
"v2_only_metrics": v2_only_metrics
}

# Write the differences to a new JSON file
differences_path = "./differences.json"
with open(differences_path, 'w') as file:
json.dump(differences, file, indent=4)

print(f"Differences written to {differences_path}")
print(f"Differences written to {differences_path}")

0 comments on commit 1c080d1

Please sign in to comment.