Skip to content

Commit

Permalink
Fix instructions for running HotROD (#650)
Browse files Browse the repository at this point in the history
## Description of the changes
- Address
https://github.com/jaegertracing/documentation/pull/648/files#r1302207961
- Fix Docker commands

## How was this change tested?
- Ran locally

Signed-off-by: Yuri Shkuro <[email protected]>
  • Loading branch information
yurishkuro authored Aug 24, 2023
1 parent b8ac666 commit cbf4222
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 20 deletions.
21 changes: 11 additions & 10 deletions content/docs/1.48/getting-started.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,8 @@ Historically, the Jaeger project supported its own SDKs (aka tracers, client lib
The simplest way to start the all-in-one is to use the pre-built image published to DockerHub (a single command line).

```bash
docker run -d --name jaeger \
docker run --rm --name jaeger \
-e COLLECTOR_ZIPKIN_HOST_PORT=:9411 \
-e COLLECTOR_OTLP_ENABLED=true \
-p 6831:6831/udp \
-p 6832:6832/udp \
-p 5778:5778 \
Expand Down Expand Up @@ -89,11 +88,8 @@ The HotROD app can be run standalone, but requires Jaeger backend to view the tr

### Running

We recommend running Jaeger and HotROD via `docker compose`. In order to run it from source you need:
We recommend running Jaeger and HotROD together via `docker compose`.

- [Go toolchain](https://golang.org/doc/install) installed on your machine
(see [go.mod](https://github.com/jaegertracing/jaeger/blob/master/go.mod) file for required Go version).
- A [running Jaeger backend](#all-in-one) to view the traces.

#### With Docker Compose

Expand All @@ -107,16 +103,21 @@ docker compose up
#### With Docker

```bash
docker run --rm -it \
--link jaeger \
docker run --rm -it --link jaeger \
-p8080-8083:8080-8083 \
-e JAEGER_AGENT_HOST="jaeger" \
-e OTEL_EXPORTER_OTLP_ENDPOINT="http://jaeger:4318" \
jaegertracing/example-hotrod:{{< currentVersion >}} \
all
all --otel-exporter=otlp
```

#### From Source

In order to run from source you need:

- [Go toolchain](https://golang.org/doc/install) installed on your machine
(see [go.mod](https://github.com/jaegertracing/jaeger/blob/master/go.mod) file for minimum required Go version).
- A [running Jaeger backend](#all-in-one) to view the traces.

```bash
git clone [email protected]:jaegertracing/jaeger.git jaeger
cd jaeger
Expand Down
21 changes: 11 additions & 10 deletions content/docs/next-release/getting-started.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,8 @@ Historically, the Jaeger project supported its own SDKs (aka tracers, client lib
The simplest way to start the all-in-one is to use the pre-built image published to DockerHub (a single command line).

```bash
docker run -d --name jaeger \
docker run --rm --name jaeger \
-e COLLECTOR_ZIPKIN_HOST_PORT=:9411 \
-e COLLECTOR_OTLP_ENABLED=true \
-p 6831:6831/udp \
-p 6832:6832/udp \
-p 5778:5778 \
Expand Down Expand Up @@ -89,11 +88,8 @@ The HotROD app can be run standalone, but requires Jaeger backend to view the tr

### Running

We recommend running Jaeger and HotROD via `docker compose`. In order to run it from source you need:
We recommend running Jaeger and HotROD together via `docker compose`.

- [Go toolchain](https://golang.org/doc/install) installed on your machine
(see [go.mod](https://github.com/jaegertracing/jaeger/blob/master/go.mod) file for required Go version).
- A [running Jaeger backend](#all-in-one) to view the traces.

#### With Docker Compose

Expand All @@ -107,16 +103,21 @@ docker compose up
#### With Docker

```bash
docker run --rm -it \
--link jaeger \
docker run --rm -it --link jaeger \
-p8080-8083:8080-8083 \
-e JAEGER_AGENT_HOST="jaeger" \
-e OTEL_EXPORTER_OTLP_ENDPOINT="http://jaeger:4318" \
jaegertracing/example-hotrod:{{< currentVersion >}} \
all
all --otel-exporter=otlp
```

#### From Source

In order to run from source you need:

- [Go toolchain](https://golang.org/doc/install) installed on your machine
(see [go.mod](https://github.com/jaegertracing/jaeger/blob/master/go.mod) file for minimum required Go version).
- A [running Jaeger backend](#all-in-one) to view the traces.

```bash
git clone [email protected]:jaegertracing/jaeger.git jaeger
cd jaeger
Expand Down

0 comments on commit cbf4222

Please sign in to comment.