[@sigma/layer-leaflet] Adding leaflet map in graph background #1447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update the sigma's graph with the projected lat/lng coordinates * Sync the sigma & leaflet view box * Add limits on sigma zoom ratio to not be outside the leaflet capabilities
|
Manually reviewed, rebased and merged 👍. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding leaflet map in graph background
What can be enhance :
flyToBoundto have smooth transition. But it's not so simple. I'm assuming there is some bounds attraction at the end of the animation. Moreover, it's not easy to know when the animation has finished. This is needed in some cases (like the recomputation of ratio bounds on a resize).