Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a new option to json_file constructor #566

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Conversation

jacobwilliams
Copy link
Owner

If nullify_pointer is False, the pointer is not nullified
Fixes #564

If nullify_pointer is False, the pointer is not nullified
Fixes #564
@LaplaceSoda
Copy link

Test results show that after adding nullify_pointer=.false., the original json_file object seems still broken.

@jacobwilliams
Copy link
Owner Author

Yeah, this doesn't really "fix" the issue you mention in #564, but it just gives another option for something somebody might want to do in some cases. Specifically, add a json pointer to a json_file, but keeping it associated, and then subsequently nullifying the one in the json_file.

@jacobwilliams jacobwilliams merged commit 08fe9c3 into master Jun 11, 2024
10 checks passed
@jacobwilliams jacobwilliams deleted the 564-nullify-option branch June 11, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After creating an new object, any remaining key-value pairs in origin json_file will be erased.
2 participants