fix: pass in post state instead of extending #47
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously we were constructing a new
PostState
in each call toexecute
, passing that back to the caller inExecution
, and callingextend
on our top-levelPostState
to merge the pre and post-execution post states. however, theextend
method did not behave according to expectations, and it would end up clearing information about the original post state.this change alters the
execute
function to take a&mut PostState
as an argument.