Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass in post state instead of extending #47

Merged
merged 1 commit into from
Aug 20, 2023
Merged

Conversation

jacobkaufmann
Copy link
Owner

previously we were constructing a new PostState in each call to execute, passing that back to the caller in Execution, and calling extend on our top-level PostState to merge the pre and post-execution post states. however, the extend method did not behave according to expectations, and it would end up clearing information about the original post state.

this change alters the execute function to take a &mut PostState as an argument.

@jacobkaufmann jacobkaufmann merged commit de526d0 into master Aug 20, 2023
1 check passed
@jacobkaufmann jacobkaufmann deleted the fix-post-state branch August 22, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant