feat: depend on self #1085
Open
feat: depend on self #1085
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
jackyzha0
reviewed
Apr 11, 2024
|
Gotcha, let me go fix that haha |
OCDkirby
force-pushed
the
IndependenceDay
branch
from
c016879
to
786a3a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that I can confirm this is working, here's my change that enables proper dependency resolution with community plugins as dependencies via NPM, which depend on a quartz-api package, which depends on quartz. The way my current quartz-api package uses this change is necessarily much more complex than the change itself, because dependency resolution is not fun.
Part of: #1062
Edit: I didn't touch the file that's failing style checks, weird