Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility improvements #832

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Accessibility improvements #832

wants to merge 10 commits into from

Commits on Mar 28, 2017

  1. Aria Accessibility compliance. fixes jackmoore#765 

    This is a formal approach to fixing jackmoore#765 with proper use of Aria
attributes as an alternative to PR jackmoore#821.

Changes include:

*  Add `aria-hidden` attributes on the dialog box and navigational
   buttons.

*  Update the `aria-hidden` value to `true` or `false` at the
   appropriate times.

*  Add `aria-label` attributes to navigational buttons, using the
   colorbox default settings at page load time, and then update the
   value when a colorbox is loaded.

*  Add `aria-labelledby` and `aria-describedby` attributes to the
   div containing `role='dialog'`.
    @jameswilson
    jameswilson committed Mar 28, 2017
    Configuration menu
    Copy the full SHA
    b3bc29a View commit details
    Browse the repository at this point in the history

  2. Pass HTML_CodeSniffer WCAG 2.0 tests

    @jameswilson
    jameswilson committed Mar 28, 2017
    Configuration menu
    Copy the full SHA
    16dc716 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2017

  1. Cleanup unneeded aria-labels, fix autoreading of dialog by using ARIA… 

    … live regions and ensure focus is on the first element in the dialog when it opens
    Unknown committed Jun 2, 2017
    Configuration menu
    Copy the full SHA
    0acca4f View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2017

  1. Fix spelling of 'aria-label'

    @jameswilson
    jameswilson committed Jun 15, 2017
    Configuration menu
    Copy the full SHA
    a2b39f2 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2017

  1. Cleanup unneeded aria-labels, fix autoreading of dialog by using ARIA… 

    … live regions and ensure focus is on the first element in the dialog when it opens
    @bramd
    bramd committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    f0919a0 View commit details
    Browse the repository at this point in the history

  2. Reworked focus trapping

    @bramd
    bramd committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    b0d406a View commit details
    Browse the repository at this point in the history

  3. Updated minified version

    @bramd
    bramd committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    066c3dd View commit details
    Browse the repository at this point in the history

  4. Merge branch '765-accessibility-compliance' of https://github.com/Blu… 

    …esparkLabs/colorbox into 765-accessibility-compliance
    @bramd
    bramd committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    0cade05 View commit details
    Browse the repository at this point in the history

  5. Merge branch '765-accessibility-compliance' of https://github.com/bra… 

    …md/colorbox into 765-accessibility-compliance
    @bramd
    bramd committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    22fdfc2 View commit details
    Browse the repository at this point in the history

  6. Merge branch '765-accessibility-compliance'

    @bramd
    bramd committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    76fc8ae View commit details
    Browse the repository at this point in the history