fix(integration): improved avoidance of Test Explorer (xcodebuild.nvim) #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@j-hui could you please take a look at this PR? |
|
Hey sorry @wojciech-kulik , I was traveling and didn't get a chance until now. |
j-hui
approved these changes
Mar 17, 2024
There was a problem hiding this comment.
This looks good to me, in that I don't think it breaks anything AFAICT as a non-user of xcodebuild.nvim.
But I'm also not entirely sure what it's doing: it's calling resize() on xcodebuild.nvim's buf number, just once, on initialization? Is this because xcodebuild.nvim may already have constructed its text explorer window by the time Fidget initializes?
|
Yes, exactly. The window could be already there if you didn't close it leaving Neovim and you use autosession. |
|
Got it, thanks for catching that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, a small improvement, now the Test Explorer can be already shown when Neovim starts, so we need to handle this case.