feat: Update fft.py #23647
feat: Update fft.py #23647
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our contributing guide and our PR template.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
Protected Branch
In order to be considered for merging, the pull request changes must not be implemented on the "main" branch. This is described in our Contributing Guide. We are closing this pull request and we would suggest that you implement your changes as described in our Contributing Guide and open a new pull request.
ivy-leaves
added
the
Paddle Frontend
|
If you are working on an open task, please edit the PR description to link to the issue you've created. For more information, please check ToDo List Issues Guide. Thank you 🤗 |
There was a problem hiding this comment.
Hi @jaskiratsingh2000 thank you for you opening this PR and working on this issue, we just have a few things to keep in mind.
When you work on issue it would be great to see if that issue is not being opened or is not work in progress by someone else. Helping them would give a better indicated than pushing to have a PR merged.
I am going to close this PR right now, feel fere to pick an open task and work on it.
|
@a0m0rajab this issue is not being done by anyone. This is a sub task of many functions. Could you once please review it again? |
|
@a0m0rajab I by mistakenly added wrong issue |
|
The issue is having open PR and it's been active. If you think you have added the wrong number of the issue please feel free to edit the PR description and let me know. |
|
the link to the open PR though; #19454 |
|
@a0m0rajab Just a confusion. Yes so this issue has been stale so long and have not been reviewed so that's why I decided to work on this. There are lots of multiple issue similar to this so I was confused if I mentioned the correct one here. Anyways yes so since previous PR was also failing test cases if I'm not wrong so that's why I worked on this |
#19383